That-One-Nerd/SrcMod
1
0
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Ready for alpha 0.4.0 (the final alpha version (hopefully)) #72

Merged
That-One-Nerd merged 16 commits from shell-configuration into main 2023-04-25 17:42:32 -04:00
Conversation 1 Commits 16 Files Changed 8 +306 -160
That-One-Nerd commented 2023-04-25 17:38:04 -04:00 (Migrated from github.com)
Copy Link

Overall, this update is largely related to the configuration system. It's almost entirely automated now, with adding new config variables as easy as adding a property in two different classes. Yeah, still sounds a bit much, but frankly I don't really know how else to do it, no matter how much reflection I use (if it's even possible). I'm pretty happy with it.

Here's the changelog:

  • Displaying the raw config info no longer writes to an unnecessary memory stream (#53).
  • The config display system is now fully automated (#54).
  • Changing config variables is now fully automated (#55).
  • Turned the config type into a mutable type (class).
  • Marked Tools and LoadingBar as public instead of internal.
  • Better exception messages are provided when compiled in debug mode (#71).
  • Detecting changes in the config system is now fully automated (#56).
Issues to Close
Overall, this update is largely related to the configuration system. It's almost entirely automated now, with adding new config variables as easy as adding a property in ~~two different~~ classes. Yeah, still sounds a bit much, but frankly I don't really know how else to do it, no matter how much reflection I use (if it's even possible). I'm pretty happy with it. Here's the changelog: - Displaying the raw config info no longer writes to an unnecessary memory stream (#53). - The config display system is now fully automated (#54). - Changing config variables is now fully automated (#55). - Turned the config type into a mutable type (class). - Marked `Tools` and `LoadingBar` as public instead of internal. - Better exception messages are provided when compiled in debug mode (#71). - Detecting changes in the config system is now fully automated (#56). <details> <summary>Issues to Close</summary> - closes #53 - closes #54 - closes #55 - closes #56 - closes #58 - closes #59 - closes #71 </details>
That-One-Nerd (Migrated from github.com) reviewed 2023-04-25 17:42:18 -04:00
That-One-Nerd (Migrated from github.com) left a comment
Copy Link

Looking good.

Looking good.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
cool and good 👍
docs update
duplicate
improvement
invalid
is this possible?
maybe
new feature
question
warm and bad 👎
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
That-One-Nerd
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: That-One-Nerd/SrcMod#72
No description provided.
Delete Branch "shell-configuration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?